From ae7356507d915820138b0b186e0b1b79f11142da Mon Sep 17 00:00:00 2001 From: Chrissy LeMaire Date: Sun, 25 Oct 2020 09:39:55 +0100 Subject: [PATCH 1/2] Add Heroku hint to Pull Request Template I didn't know where to look until someone pointed it out in one of my own PRs. It's possible that the heroku link can be found prior to a PR. I'll check once I submit this commit. --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 877920ee7c94..1d191f71a4e0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -22,6 +22,6 @@ Thanks again! ### Check off the following: - [ ] All of the tests are passing. -- [ ] I have reviewed my changes in staging. +- [ ] I have reviewed my changes in staging (look for the **deploy-to-heroku** link in the resulting Pull Request). - [ ] For content changes, I have reviewed the [localization checklist](https://github.com/github/docs/blob/main/contributing/localization-checklist.md) - [ ] For content changes, I have reviewed the [Content style guide for GitHub Docs](https://github.com/github/docs/blob/main/contributing/content-style-guide.md). From 67c7b9c0ec8ad814c821db520bb062035ef437eb Mon Sep 17 00:00:00 2001 From: Janice Date: Tue, 17 Nov 2020 13:10:49 -0700 Subject: [PATCH 2/2] Update .github/PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1d191f71a4e0..69d8ee5fe9a1 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -22,6 +22,6 @@ Thanks again! ### Check off the following: - [ ] All of the tests are passing. -- [ ] I have reviewed my changes in staging (look for the **deploy-to-heroku** link in the resulting Pull Request). +- [ ] I have reviewed my changes in staging. (look for the **deploy-to-heroku** link in your pull request, then click **View deployment**) - [ ] For content changes, I have reviewed the [localization checklist](https://github.com/github/docs/blob/main/contributing/localization-checklist.md) - [ ] For content changes, I have reviewed the [Content style guide for GitHub Docs](https://github.com/github/docs/blob/main/contributing/content-style-guide.md).