Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Include/Utilise XDG / Appdata Locations #98

Open
JayRovacsek opened this issue Jun 13, 2023 · 2 comments
Open

Feature Request - Include/Utilise XDG / Appdata Locations #98

JayRovacsek opened this issue Jun 13, 2023 · 2 comments

Comments

@JayRovacsek
Copy link

G'day! Firstly, thanks for this package and the other lancache prefill packages 😄

I'd like to utilise the applications on my desktop but have the config and prefill payloads save to a standard location irrespective of when I run the application. I believe if the project is open to it, XDG for Linux/MacOS would make sense, and an Appdata folder on Windows.
On the inability to identify the correct directory, the fallback would be current design of the applications execution context.

My C# is rusty, but happy to give it a crack if the idea is considered suitable - it may be worth noting this is something I'd love to see across epic, steam and battlenet but the respective code for each is not within the lancache prefill module - keen to hear your thoughts on where the code would live if you're open to the above proposed feature @tpill90

Thanks!

@tpill90
Copy link
Owner

tpill90 commented Jun 16, 2023

Hi @JayRovacsek ,

I just want to make sure I'm understanding what you mean correctly. You're saying that you would like to have the prefills be able to placed in any folder, but it would pickup the correct settings from AppData for example?

Or do you mean that you'd like to run a prefill from any working directory, but it still uses the correct settings located with the prefill? For example if I had the executable in C:\Program Files\BattlenetPrefill and used a working directory of C:\Users\me it would still pickup the correct settings file in C:\Program Files\BattlenetPrefill\Config?

@JayRovacsek
Copy link
Author

JayRovacsek commented Jun 17, 2023

Hey @tpill90! Looking at the GetCacheDirBaseDirectories (in common code) function in the shared code that space is great as it stands

My query to clarify, would to change the behaviour of the ConfigDir from the AppContext.BaseDirectory value to instead the same space as the cache directory across BN, Steam and Epic packages.

My rationale for this is for two reasons

  • between versions a user may opt to download a new version over using the update.ps1 or update.sh leading to new directory not identifying previous settings
  • as an edge-case, execution from a read-only directory causes a crash when attempting to write the config and inability to run the application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants