-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type-related terminology is confusing, perplexing, misleading, disconcerting, disorienting #72
Comments
🤣 yes this is correct |
Or use |
@adiroiban: but see #62 and #65. |
Thanks for the links. Good work with the extension.
Maybe just go with There are many things that are confusing (start_string vs start_line) I think that is ok if we accumulate more of these issues and do a change in towncrier v1 Here is a suggestion
|
Just an update. The [tool.towncrier]
[[tool.towncrier.type]]
directory = "deprecation"
name = "Deprecations"
showcontent = true
[[tool.towncrier.type]]
directory = "chore"
name = "Other Tasks"
showcontent = false
[[tool.towncrier.type]]
directory = "deps"
name = "Dependency Changes"
showcontent = true
check = false Happy to receive suggestions on how to improve this. |
The config file has a concept of different types of fixes, they're configured through a section called
type
. OK.The code calls them categories everywhere. O...kay? I know type collides with the python builtin but switching to distinguishing between sections and categories? That's way worse. Though at least only people reading the code run into this.
And then the way you configure the file name used for a type/category is by the key
directory
, which does not specify a directory at all. C'MON.(Maybe
tag
orslug
or something?)The text was updated successfully, but these errors were encountered: