Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operations to not throw Exceptions #125

Open
ht-gong opened this issue Jul 26, 2022 · 1 comment
Open

Operations to not throw Exceptions #125

ht-gong opened this issue Jul 26, 2022 · 1 comment

Comments

@ht-gong
Copy link
Contributor

ht-gong commented Jul 26, 2022

Currently add/delete_node/edge throws an exception if a WT error other than WT_Rollback (or sometimes WT_notfound) is encountered -- change all of these to return an error code instead of throws

@artorhem
Copy link
Collaborator

Throwing exceptions HAS to be avoided. Need to go through the code to see where we really do need to throw an exception and where a simple error log will suffice.

for example: in get_out_node_id(), if there is no valid out neighborhood, we throw an exception, which is absolutely wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants