Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should match superclass not working with if else #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: should match superclass not working with if else #324

wants to merge 1 commit into from

Conversation

MVitelli
Copy link
Contributor

Fix #307

@MVitelli MVitelli requested a review from fdodino December 23, 2024 23:05
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (59c43f7) to head (a2d39db).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   89.69%   89.72%   +0.02%     
==========================================
  Files          28       28              
  Lines        3183     3192       +9     
  Branches      579      581       +2     
==========================================
+ Hits         2855     2864       +9     
  Misses        172      172              
  Partials      156      156

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdodino fdodino Awaiting requested review from fdodino

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@MVitelli