-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plainAddPlaceholder breaks the PDF file with existing annotations #198
Comments
Hi @symbianm ,
|
Hi @vbuch sorry for the delay, and thanks for the details. Here is my version if someone is looking for a resolution:
|
Thank you for the input @symbianm It was just the thing I was about to do on the placeholder-pdf-lib PR. Here is my take on it and here is how I test this Once I rewrite the history so it makes more sense, I'll be welcoming reviews on this PR. I think it's important to note that currently pdf-lib does not provide incremental updates so it is very likely that adding a new signature on top of the previous one invalidates the first one. |
Describe the bug and the expected behaviour
When using a file with the existing form annotations and adding a placeholder using plainAddPlaceholder it breaks the PDF file.
Acrobat Reader gives an error. MacO's preview misses all text. But Chrome opens it okay.
Results are random and it depends on which annotations it has.
Is it a bug in signing or in the helpers?
Issue with
@signpdf/placeholder-plain
packageTo Reproduce
Using the slightly modified example from here:
https://github.com/vbuch/node-signpdf/blob/develop/packages/examples/src/javascript.js
The
certificate.p12
is from your repo https://github.com/vbuch/node-signpdf/blob/develop/resources/certificate.p12PDF files:
document2.pdf
document.pdf
The text was updated successfully, but these errors were encountered: