Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only one article to be pinned at any time #1710

Closed
Magssch opened this issue Oct 15, 2019 · 7 comments · Fixed by #2355
Closed

Allow only one article to be pinned at any time #1710

Magssch opened this issue Oct 15, 2019 · 7 comments · Fixed by #2355
Assignees

Comments

@Magssch
Copy link

Magssch commented Oct 15, 2019

If possible, it would be nice to allow only one article to be pinned at any time, and for pins to be deactivated for other articles -- either when pinning a new article -- or to be time-restricted and automatically be unpinned after, say, 2 weeks.

This rule need not apply to events, as they will disappear anyways after the event has taken place.

@odinuge
Copy link
Member

odinuge commented Oct 15, 2019

Work in progress here: #1302 & webkom/lego-webapp#1351

@JonasBak
Copy link
Member

tl;rd: Maybe add ability to unpin all other articles instead of forcing only one?

I started looking into this, but after asking the people that use the pinning feature and looking at how it was used, I figured what I wanted (ability to pin everything for specific groups between dates) was a bit overkill and I think it would have been more unnecessary than it would have helped. I imagine that a simple feature like this would be more useful.

If we fix something like #1709, what exactly is the issue? I'm guessing that the main thing is that when you don't want to have something pinned anymore you unpin it, but then something old shows up? But then why is that old thing pinned in the first place, and why can't we just remove that as well? I imagine that it's because we share space with events, so old pinned articles get hidden and forgotten when events take their space, so if we don't share this space, it'll be easier to have a "clean pinboard".

The reason I'm being skeptical is because I think articles sometimes are used as "announcement boards" for stuff that doesn't have the lifespan of a readme article, but it might take precedence for a little while (for example https://abakus.no/articles/209, https://abakus.no/articles/207, https://abakus.no/articles/206), so if we pin these for just a few days and remove old pins when pinning them, we'll have to dig up what used to be pinned earlier, which I imagine is just as much work (although not much) as not having the feature and just remembering to unpin stuff we don't want there. Therefore I think the ability to remove old pins when pinning something new might be the sweet spot.

@Magssch
Copy link
Author

Magssch commented Oct 16, 2019

Mostly the problem is that so many people are creating articles, and it is difficult to not forget unpinning an article. Usually I think every article should be pinned until a new one is created. I do agree that we could include the option to remove every other pin when pinning a new article, but in practice I think this will just end up becoming another checkbox that people tend to forget to check. I think digging though the articles once in a while if we need to re-pin something is much less work than continually having to remember to unpin articles.

@Magssch
Copy link
Author

Magssch commented Oct 16, 2019

In any case though, the option to remove every pin when pinning new articles is much better than the current solution.

@JonasBak
Copy link
Member

Usually I think every article should be pinned until a new one is created

So we should basically stop using pins and just showing the latest article then. I feel like the biggest issue is that pinning is used wrong, almost all new articles are pinned, which takes away the point. I imagine the reason why all articles are pinned are because people want their post to be seen, so I sort of feel like the better solution is to make stricter rules about what is pinned, and to give articles more space on the front page in general.

@SmithPeder
Copy link
Member

SmithPeder commented Apr 6, 2021

This!!

tl;rd: Maybe add ability to unpin all other articles instead of forcing only one?

I think we should just make a simple quick feature where on_create_or_edit_article() where pinned=True then find_and_unpinn_all_other_articles()

This applies to events as well, there should only be one pinned thing at a time (with the current design)

@Magssch
Copy link
Author

Magssch commented Apr 7, 2021

+1 Peder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants