Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default GKE specific tolerations #387

Open
juhosyrjanen opened this issue Sep 9, 2024 · 3 comments
Open

Remove default GKE specific tolerations #387

juhosyrjanen opened this issue Sep 9, 2024 · 3 comments

Comments

@juhosyrjanen
Copy link

Hello,

By default the Helm chart adds GKE specific tolerations to Wiz Sensor DaemonSet. This causes issues with EKS based deployments. The following values fix needs to be added in order to have Wiz correctly deploy on EKS.

wiz-sensor:
  daemonset:
    tolerations:
      - operator: "Exists"

ArgoCD diff shows the change as follows:

image

This default makes using the Helm chart in multi-cloud deployments a bit cumbersome.

@ariknem
Copy link
Contributor

ariknem commented Sep 9, 2024

Hmm this is specifically when deploying with ArgoCD I'm guessing? Can you tell me what issues you're getting?

@juhosyrjanen
Copy link
Author

juhosyrjanen commented Sep 9, 2024

Hi, thanks for the quick reply!

By default, as these defaults are in place, the resources provisioned by the Helm chart are not able to schedule on AWS EKS based clusters. This can be overridden with the values.daemonset.tolerations config as shown above.

This is essentially a minor bug fix, a user experience improvement as EKS/AKS etc users will have to override these defaults to use the chart.

I suggest removing these defaults, or adding a values.cloudProvider config option that either disables or enables these as needed.

This is not related to ArgoCD.

@ariknem
Copy link
Contributor

ariknem commented Sep 10, 2024

How are you installing the sensor? Using a helm chart? I've never had issues when doing "helm install" and this is the first customer complaint I've seen.

We aim to be as automatic as possible, so we don't want to configure per cloud provider. Note that you can always override the tolerations directly in your install cmdline:
--set daemonset.tolerations=....

Are you installing via the unified helm chart (https://github.com/wiz-sec/charts/tree/master/wiz-kubernetes-integration) or the sensor helm chart (https://github.com/wiz-sec/charts/tree/master/wiz-sensor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants