-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default GKE specific tolerations #387
Comments
Hmm this is specifically when deploying with ArgoCD I'm guessing? Can you tell me what issues you're getting? |
Hi, thanks for the quick reply! By default, as these defaults are in place, the resources provisioned by the Helm chart are not able to schedule on AWS EKS based clusters. This can be overridden with the This is essentially a minor bug fix, a user experience improvement as EKS/AKS etc users will have to override these defaults to use the chart. I suggest removing these defaults, or adding a This is not related to ArgoCD. |
How are you installing the sensor? Using a helm chart? I've never had issues when doing "helm install" and this is the first customer complaint I've seen. We aim to be as automatic as possible, so we don't want to configure per cloud provider. Note that you can always override the tolerations directly in your install cmdline: Are you installing via the unified helm chart (https://github.com/wiz-sec/charts/tree/master/wiz-kubernetes-integration) or the sensor helm chart (https://github.com/wiz-sec/charts/tree/master/wiz-sensor) |
Hello,
By default the Helm chart adds GKE specific tolerations to Wiz Sensor DaemonSet. This causes issues with EKS based deployments. The following values fix needs to be added in order to have Wiz correctly deploy on EKS.
ArgoCD diff shows the change as follows:
This default makes using the Helm chart in multi-cloud deployments a bit cumbersome.
The text was updated successfully, but these errors were encountered: