Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Products] Improve handling of Product Preview button to work with "Coming Soon" feature #13353

Open
hichamboushaba opened this issue Jan 20, 2025 · 1 comment
Open

[Products] Improve handling of Product Preview button to work with "Coming Soon" feature #13353

hichamboushaba opened this issue Jan 20, 2025 · 1 comment
Labels
feature: product details Related to adding or editing products, includes product settings. priority: medium Planned tasks usually belonging to ongoing projects type: enhancement A request for an enhancement.

Comments

@hichamboushaba
Copy link
Member

When a site's visibility is set to "Coming soon", the product preview works only when the user is authenticated.

To make this work with our "View product" button in product details, we need to:

  • Introduce a more generic authenticated webview that works with both WPCom and Site credentials (check AuthenticatedWebView in iOS)
  • Use it instead of the Chrome custom tabs.

Also, revisit the logic to see if we should show the button when the product visibility is set to "private", as this should make it work now in all cases.
@hichamboushaba hichamboushaba added feature: product details Related to adding or editing products, includes product settings. type: enhancement A request for an enhancement. priority: medium Planned tasks usually belonging to ongoing projects labels Jan 20, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 20, 2025 •
edited
Loading

Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature: product details Related to adding or editing products, includes product settings. priority: medium Planned tasks usually belonging to ongoing projects type: enhancement A request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hichamboushaba @dangermattic