[Shipping Labels Revamp] Introduce Customs initial form #13378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomazFB
added
type: task
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
|
Version |
…ther Details text fields
…duce-customs-section
ThomazFB
changed the base branch from
trunk
to
issue/add-initial-customs-entry-point
…duce-customs-section
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue/add-initial-customs-entry-point #13378 +/- ##
===========================================================================
+ Coverage 41.12% 41.15% +0.03%
- Complexity 6497 6507 +10
===========================================================================
Files 1326 1327 +1
Lines 77601 77661 +60
Branches 10699 10701 +2
===========================================================================
+ Hits 31913 31964 +51
- Misses 42851 42860 +9
Partials 2837 2837 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Partially fix issue #13366 by introducing the initial Customs form connected with the main Shipping Labels creation form.
The data validation and error handling will be delivered in the following PR.
The Product Details section will be delivered through issue #13367.
How
Introduces the ViewModel, Screen, and Fragment set for the Customs form, with the navigation action coming from the Shipping Labels creation form. It also defines the basic UI structure alongside the Content, Restriction, and ITN fields, with proper support for the
Otheroption, opening an additional Text field for additional description.Unit tests are also added for the ViewModel viewState and events controls.
Screen Capture
Screen_recording_20250130_144547.mp4
How to Test
In case you want to avoid having to fill the address data to access the Customs form, you can simply override the
ShouldRequireCustomsFormuse case always to return true to trigger the Customs data requirement forcefully.Update release notes:
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: