-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wpimath] PIDController field and method names for error and errorDerivative #7088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except the old PIDController error methods should be deprecated instead of immediately removed.
Will do. I need to finish up the C++ as well. I’ll challenge myself next time and do the C++ first. Quick general question. Is a PR for RobotPy required only for commands or for every package. I have no problem making them. I just wanted to make sure not to break anything |
RobotPy PRs are only needed for pure Python ports, like commands. The rest is autowrapped. |
Robotpy is primarily done by wrapping C++. Only commands is done by writing pure Python, which is why there needs to be Python changes for changes in commands. |
wpimath/src/main/java/edu/wpi/first/math/controller/ProfiledPIDController.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/math/controller/PIDController.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/math/controller/PIDController.java
Outdated
Show resolved
Hide resolved
…DController.java Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
/format |
I replaced positionError with error and velocityError with errorDerivative across the fields and methods.
I also added a few items to the initSendable for tuning purposes.