Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanism2d Java lacks SendableRegistry add and close #7688

Open
shueja opened this issue Jan 15, 2025 · 2 comments
Open

Mechanism2d Java lacks SendableRegistry add and close #7688

shueja opened this issue Jan 15, 2025 · 2 comments
Labels
type: bug Something isn't working.

Comments

@shueja
Copy link
Contributor

shueja commented Jan 15, 2025

Mechanism2d needs to have SendableRegistry.add(this, "Mechanism2d", m_instance) and similar removal in close(). Currently, SmartDashboard.putData(mechanism2d) doesn't work because the registry doesn't have a name for the Mechanism2d.

@shueja shueja added the type: bug Something isn't working. label Jan 15, 2025
@PeterJohnson
Copy link
Member

I'm not sure we want this behavior, as unnamed Mechanism2d's don't seem very useful? You can putData() with a name, correct?

@shueja
Copy link
Contributor Author

shueja commented Jan 15, 2025

You can, but it's an API consistency issue. When only using one Mechanism2d and just trying to get it showing, I was thrown off by the fact that the "log-any-Sendable" putData didn't do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants