Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method = both works differently for STATA and R packages #23

Open
ahmedchaudhryy opened this issue Jun 30, 2021 · 1 comment
Open

method = both works differently for STATA and R packages #23

ahmedchaudhryy opened this issue Jun 30, 2021 · 1 comment

Comments

@ahmedchaudhryy
Copy link

Hello,

Thank you for your amazing work with this package and the paper.

I have used the fect package on both R and STATA using the same dataset. When I specify method = "both" (while allowing cv to pick the best lambda or r) in either STATA or R, the model selection differs, on STATA it is picking up MC with lambda = 0 as the preferred model while on R its picking ife with r =3.

Can you please look into this matter? Which software's results should I trust more in this case?

Also a small request: Would it be possible to allow customization in the plot in R? In STATA we can choose the desired pre and post-treatment periods to be displayed on the plot, but it not exactly possible in R plot. We can choose proportion in R but it does not exactly work the same way as in choosing pre and off-periods. For example, I would want a plot with -14 pre-treatment periods and 6 post-treatment periods in R as well.
(This would be really helpful in finalizing my estimates if R's results are to be trusted in model selection).

Thank you in advance!

@xuyiqing
Copy link
Owner

xuyiqing commented Jun 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants