You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're seeing this plugin report a negative requests count metric just before Puma (in our case in a Kubernetes pod) shuts down. I'm assuming that the counters are cleared at some point during the shutdown process (or perhaps the workers shut down before the master process) and that when we calculate the request count we end up subtracting from zero.
Would you accept a patch that ensures that requests count never returns less than zero? Happy to submit a PR if so.
The text was updated successfully, but these errors were encountered:
We're seeing this plugin report a negative requests count metric just before Puma (in our case in a Kubernetes pod) shuts down. I'm assuming that the counters are cleared at some point during the shutdown process (or perhaps the workers shut down before the master process) and that when we calculate the request count we end up subtracting from zero.
Would you accept a patch that ensures that requests count never returns less than zero? Happy to submit a PR if so.
The text was updated successfully, but these errors were encountered: