Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goctl rpc new did not works well #4588

Open
dbinggo opened this issue Jan 19, 2025 · 2 comments
Open

Goctl rpc new did not works well #4588

dbinggo opened this issue Jan 19, 2025 · 2 comments

Comments

@dbinggo
Copy link

dbinggo commented Jan 19, 2025

Describe the bug
A clear and concise description of what the bug is.

when I run "goctl rpc new xxx " is ok
bug when I run "goctl rpc new path1/path2/xx" It dos not ok
It looks like double dir_path like "path1/path2/xx/path1/path2/xx" and have fault message

To Reproduce
Steps to reproduce the behavior, if applicable:

  1. The code is

    goctl rpc new "./app/test" --style=go_zero
  2. The error is

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environments (please complete the following information):

  • OS: mac 15.1
  • goctl version goctl version 1.7.3 darwin/arm64

More description
Add any other context about the problem here.

Image

double app dir

@kesonan
Copy link
Collaborator

kesonan commented Jan 20, 2025

goctl rpc new $service_name, $service_name isn't output directory, if you use directory path as service name, it means a proto file would be created in it, and protoc generates pb files will depend on the proto filepath, so why this issue happend.

@dbinggo
Copy link
Author

dbinggo commented Jan 20, 2025

Can support --path to set the output directory in the feature ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants