Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Migration from 6.5.9 to 6.5.10/6.5.11 did not update references to MomentJS+JQuery-UI and CKEditor #630

Open
johnnyapol opened this issue Jan 18, 2025 · 1 comment
Assignees
Labels
4 - clarification The issue or pull requests needs more information.

Comments

@johnnyapol
Copy link

Environment

  • Server OS: Linux (docker)
  • Browser: Firefox
  • Znuny version: upgrading from 6.5.9 -> 6.5.11

Expected behavior

The settings changed in Kernel/Config/Files/XML/Framework.xml and Kernel/Config/Files/XML/Calendar.xml in ee8cd0f and ee8cd0f would be automatically adjusted when running the migrations and update commands.

Actual behavior

The settings were not migrated which caused the web frontend to not function as I run Znuny inside a container, where the old momentjs/jquery paths no longer existed the when the container was rebuilt for the new version. This caused a browser too old error to occur on the login screen and the agent view to be completely broken. This also likely means people who upgraded existing installs are not using the newer versions and the issue is being masked if they didn't clean the directory and just installed over it.

How to reproduce

Steps to reproduce the behavior:

  1. Purge the old momentjs, ckeditor, and jquery-ui paths from the filesystem
  2. Upgrade an existing Znuny 6.5.9 install to Znuny 6.5.11 following the instructions on https://doc.znuny.org/znuny_lts/releases/installupdate/update/update-6.5.html
  3. Observe that you cannot login and existing sessions encounter Javascript errors in the console

Additional information

While an automatic migration is nice, having the settings we need to adjust documented in the release notes for 6.5.10 (momentjs and jquery-ui) and 6.5.11 (CKeditor) would also be sufficient. Looking at the git diffs allowed me to figure out what settings needed to be changed but that likely is intimidating for some people.

Screenshots

n/a

@johnnyapol johnnyapol changed the title Bug - Migration from 6.5.9 to 6.5.10/6.5.11 did not update references to MomentJS+JQuery-UI and CKEditorK Bug - Migration from 6.5.9 to 6.5.10/6.5.11 did not update references to MomentJS+JQuery-UI and CKEditor Jan 18, 2025
@hanneshal
Copy link

Hi @johnnyapol
this behaviour can not be observed in a default installation. In the most cases this usually happens when someone or a package made modifications to the default config. The sysconfig updaten then does not touch user modified settings. This has always been handled this way. The sysconfig assumes that it should not modify it and that the user takes care of this.

You can check your sysconfig export or the sysconfig itself on the "old" version for a vertical gray bar next to the entry.

Regards
Johannes

@hanneshal hanneshal self-assigned this Jan 20, 2025
@hanneshal hanneshal added the 4 - clarification The issue or pull requests needs more information. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - clarification The issue or pull requests needs more information.
Development

No branches or pull requests

2 participants