Доработаны диагностические сообщения в проверке md-object-attribute-comment-incorrect-type #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject-attribute-comment-incorrect-type
…eature/1340-md-object-attribute-comment-incorrect-type-imp-msg
iArtemv
reviewed
Jun 22, 2023
...s/com.e1c.v8codestyle.md/src/com/e1c/v8codestyle/md/check/MdObjectAttributeCommentCheck.java
Outdated
Show resolved
Hide resolved
| resultAceptor.addIssue(DEFAULT_CHECK_MESSAGE, BASIC_FEATURE__TYPE); | ||
| String msg = MessageFormat.format(Messages.MdObjectAttributeCommentCheck_message, | ||
| Messages.MdObjectAttributeCommentCheck_Is_compound_type); | ||
| resultAceptor.addIssue(msg, BASIC_FEATURE__TYPE); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Для получения eContainer() определенного типа ближайший вверх, можно использовать утильный метод EcoreUtil2.getContainerOfType
...s/com.e1c.v8codestyle.md/src/com/e1c/v8codestyle/md/check/MdObjectAttributeCommentCheck.java
Show resolved
Hide resolved
Т.к. эти проверки проверяют реквизит "Комментарий" у объектов метаданных, решили в свое время объединить в одну. Никто не был против. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что сделано
Чек-лист
Общее:
masterи нет конфликтовЕсли применимо:
Закрываемые задачи
Closes #1340
Closes #1345