-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bootstrap 5 #72
Conversation
for more information, see https://pre-commit.ci
This is great! We should hold off until jupyterhub 5 is rolled out to the veda hubs, as we're currently still on jupyterhub 4.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @oliverroick ✨ ! Do you want to fix the conflicts in this PR so we can merge and try this out in a JupyterHub 5 setup?
@GeorgianaElena I fixed the failing tests. This should be good to go now. |
I fixed some of them but not all. I'll try get back to this tomorrow. |
Alright, all fixed! |
Implements #45
h2
elements instead of custom label heading