Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bootstrap 5 #72

Merged
merged 11 commits into from
Dec 19, 2024
Merged

Upgrade to Bootstrap 5 #72

merged 11 commits into from
Dec 19, 2024

Conversation

oliverroick
Copy link
Collaborator

Implements #45

  • Updates form CSS classes, so we're using more Bootstrap CSS classes, specifically for error messaging. This allows us to remove some of the custom classes.
  • Update typography: Use h2 elements instead of custom label heading

@oliverroick oliverroick requested a review from yuvipanda November 7, 2024 05:12
@yuvipanda
Copy link
Member

This is great! We should hold off until jupyterhub 5 is rolled out to the veda hubs, as we're currently still on jupyterhub 4.x

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oliverroick ✨ ! Do you want to fix the conflicts in this PR so we can merge and try this out in a JupyterHub 5 setup?

@oliverroick
Copy link
Collaborator Author

@GeorgianaElena I fixed the failing tests. This should be good to go now.

@yuvipanda
Copy link
Member

Unfortunately it looks like Bootstrap 5 will now automatically switch to 'dark mode' if your system is using dark mode, and our selection CSS looks pretty bad on it:

image image

@yuvipanda
Copy link
Member

I fixed some of them but not all. I'll try get back to this tomorrow.

@yuvipanda
Copy link
Member

image image

The titles of the dropdown items are still the wrong color, and I'm not sure what css selector those are.

@yuvipanda
Copy link
Member

Alright, all fixed!

@yuvipanda yuvipanda merged commit 91639ac into main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants