Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom codec callback in avifEncoder #2381

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Aug 9, 2024

No description provided.

Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yannis: I only took a cursory look at this pull request. The commit message has the subject line "Add custom codec callback in avifEncoder". That is confusing, because these callbacks do not seem to provide access to a custom AV1 codec. Should we change "custom codec" to "custom encode data"?

include/avif/avif.h Outdated Show resolved Hide resolved
@y-guyon
Copy link
Collaborator Author

y-guyon commented Sep 17, 2024

Yannis: I only took a cursory look at this pull request.

Thank you. This PR is a proof-of-concept to kickstart a discussion, not a request to merge code.

The commit message has the subject line "Add custom codec callback in avifEncoder". That is confusing, because these callbacks do not seem to provide access to a custom AV1 codec.

I did not mention AV1. This could be used for any kind of coded samples (AV2?) but to be compliant with the AVIF specification it would have to be AV1 samples indeed.

Should we change "custom codec" to "custom encode data"?

To me the piece of software that generates encoded data is a codec, so "custom codec callback" is accurate. Whether that is used to feed already compressed samples or to actually encode pixels on the spot, it is opaque to the libavif API.

@y-guyon
Copy link
Collaborator Author

y-guyon commented Oct 8, 2024

Note that avifCodecEncodeImageFunc can use avifEncoderCustomEncodeImageArgs too. It can be implemented in another PR to simplify the review of this PR.

@y-guyon
Copy link
Collaborator Author

y-guyon commented Oct 8, 2024

I tagged the new avifEncoder fields as "Experimental feature" as there may be overlooked edge cases. I do not think introducing a new EXPERIMENTAL CMake flag is worth it.

The new API can be fuzzed in another PR once the design is settled.

include/avif/avif.h Outdated Show resolved Hide resolved
include/avif/avif.h Outdated Show resolved Hide resolved
include/avif/avif.h Outdated Show resolved Hide resolved
@y-guyon
Copy link
Collaborator Author

y-guyon commented Oct 9, 2024

I had another go at it to answer Maryla's comments but the added API starts to be large. I wonder if this is still worth it. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants