Logcap #668
Open
Logcap #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Teo <teocns@gmail.com>
Rich formatted text with various styles (color, bold, italic) Direct ANSI codes with proper newlines Mixed color text in both stdout and stderr All ANSI codes are preserved in the logged output Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
Added a private _make_request method that handles all the common request logicSimplified the public HTTP methods (GET/POST/PUT/DELETE) to use the common handlerEach method only specifies its unique parameters and passes them to _make_requestAdded DELETE method for completenessMaintained all existing error handling and response processingKept the connection pooling and header preparation logic unchanged Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
…it from `Session` Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
…ed for this session Signed-off-by: Teo <teocns@gmail.com> logger -> agentops_logger Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
…ssion Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
…tion Signed-off-by: Teo <teocns@gmail.com>
…_sesssion" Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
Signed-off-by: Teo <teocns@gmail.com>
…tegers or slices, not str Signed-off-by: Teo <teocns@gmail.com>
|
The current implementation has a potential issue: it doesn't guarantee that logs from one session won't leak into another when running concurrently. This needs to be addressed with callstack lookup or other methods. @areibman: otherwise, how does agentops actually know which session to assign llm events to? would the same mechanism work? |
…uests) Signed-off-by: Teo <teocns@gmail.com>
…d url Signed-off-by: Teo <teocns@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture terminal output to be displayed in the agentops dashboard. Session-based capture functionality is currently under development. Captures will be displayed in the AgentOps dashboard under "Terminal".
At the moment we capture:
logging.info(),logging.error(), etc.print()Key changes in this PR:
_make_requestmethodagentops_sessionandagentops_initwhich promotes auto setup/teardown.