Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPIAnnealing: distribute statistics to all workers #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MPIAnnealing: distribute statistics to all workers #19

wants to merge 1 commit into from

Conversation

lijun99
Copy link
Contributor

@lijun99 lijun99 commented Aug 17, 2019

The bcast the statistics (acceptance/rejection) to all workers was missing; therefore only the master thread updated the scaling.
With the newly added MPI_Allreduce to pyre, this is now done in an easier way.

aivazis
aivazis reviewed Aug 22, 2019
View reviewed changes
Copy link
Member

@aivazis aivazis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it important for each worker to see the resampling statistics? If i'm not mistaken, the manager rescales the covariance matrix and then publishes to everybody. Is this a feature you need for an extension to the current altar algorithms?

@lijun99
Copy link
Contributor Author

lijun99 commented Aug 22, 2019

That will also work; but is not being done in current code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aivazis aivazis aivazis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lijun99 @aivazis