-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merged object to AUCell workflow #1023
base: main
Are you sure you want to change the base?
Add merged object to AUCell workflow #1023
Conversation
This reverts commit dcc1ac3.
…cell-ewing-merged
Hmm it looks like GHA doesn't have the credentials to download from the workflow results bucket? |
I suspect the more accurate statement is that |
I think you are missing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Suggested a few changes, but don't need to see again.
I'd recommend updating the scripts/README
usage as well here:
OpenScPCA-analysis/analyses/cell-type-ewings/scripts/README.md
Lines 188 to 194 in 31c786e
To run this script using the default parameters use the following command: | |
```sh | |
Rscript 01-aucell.R \ | |
--sce_file <path to processed SCE file> \ | |
--output_file <path to TSV file to save AUC results> | |
``` |
Also, while I was finding this line in that README, I came across this line which has the wrong extension - it should be .R
not .Rmd
:
OpenScPCA-analysis/analyses/cell-type-ewings/scripts/README.md
Lines 303 to 309 in 31c786e
```sh | |
Rscript 04-run-infercnv.Rmd \ | |
--annotations_file <path to save annotations file> \ | |
--reference_cell_file <path to file with table of normal cell barcodes> \ | |
--output_dir <full path to folder to save results> \ | |
--threads 4 | |
``` |
analyses/cell-type-ewings/scripts/aucell-ews-signatures/01-aucell.R
Outdated
Show resolved
Hide resolved
analyses/cell-type-ewings/scripts/aucell-ews-signatures/01-aucell.R
Outdated
Show resolved
Hide resolved
analyses/cell-type-ewings/scripts/aucell-ews-signatures/01-aucell.R
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephanie Spielman <stephanie.spielman@gmail.com>
Purpose/implementation Section
Please link to the GitHub issue that this pull request addresses.
Addresses #1017
What is the goal of this pull request?
I would like to be able to look at cell type assignments on all samples together rather than trying to assign cell types individually. To do that we want to look at the merged object, in particular we want to have AUCell results from the merged object.
Briefly describe the general approach you took to achieve this goal.
This PR makes the necessary modifications to the workflow and script that runs
AUCell
.is_merged
option to deal with any special circumstances for the merged object. The formatting is slightly different so this affects filtering the SCE object to remove any non-detected genes.sparse DelayedMatrix object of type "double"
so is showing the 0s and then causes an error when used as direct input toAUCell
. I'll file an issue inscpcaTools
where we make the merged object, because I think we do want to make sure the output there is actually adgCMatrix
.If known, do you anticipate filing additional pull requests to complete this analysis module?
Yes. I already started looking at the results here to make sure this was a reasonable thing to spend time on. So next will be a PR that looks at the results in an exploratory notebook using the template that we have as a guide to create that notebook.
Results
What is the name of your results bucket on S3?
s3://researcher-211125375652-us-east-2/cell-type-ewings/results/aucell-ews-signatures
What types of results does your code produce (e.g., table, figure)?
There should be TSV files with the results. I re-ran the whole workflow and copied the updated files for individual libraries and the merged library to S3.
What is your summary of the results?
Coming next!
Author checklists
Analysis module and review
README.md
has been updated to reflect code changes in this pull request.Reproducibility checklist
Dockerfile
.environment.yml
file.renv.lock
file.