Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 00-reference to build azimuth kidney reference #706
Adding 00-reference to build azimuth kidney reference #706
Changes from 1 commit
6a23d16
20f04e0
4691f7d
bd2a7e0
7fb795d
0f2bc73
557df2c
d02eaa8
9deb67c
3d8268e
3ab1e5e
dad3312
4282e29
6c70fbe
cc22690
7d60c65
b081722
c7deac5
470d073
a47e8c2
3d32a5b
f6daa9b
4c3ba05
9ce015e
b9f5eff
8eecdf5
430b080
c480e83
4eef88a
4cf4b70
ce31417
c8fffe1
b1f6b84
7060f5c
01b81b8
70d61b4
513f7de
1c3dda4
9aeda5b
3f7458f
9cd70dd
8c4e6f4
fd0a140
9abb234
0e55ed5
c01a3ad
0705141
4b761a4
268c648
f05dc97
0fcaaed
6d0f854
878dc04
f98da21
36fa88e
578f2bc
4d96949
41549c0
f6d6aec
036e799
0ed2e63
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was poking around locally to see if I could better understand the Azimuth problem, and I think we need to get
SeuratWrappers
into therenv.lock
file.I was able to install from RStudio within the Docker container with:
(This is the most recent commit.)
If you run
renv::snapshot()
, I expect some packages might get removed because the code in this branch doesn't account for what is getting added in #704. That would be okay, though; we'd need to resolve it in whichever branch gets merged second.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would need to change this text if using
params
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could move this URL to a parameter with this as the default. I'll comment above with that suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this text to reflect whatever happens in the chunk below!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you'd like, you could still read what is in
scratch
for this plotting. Although, doesdo_DimPlot()
perform any normalization? Would it be more appropriate to plot after the steps in 117-119? That would change my strategy a bit for the script I proposed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if you have had any luck running
AzimuthReference
within a script? 🤔 Because if so, maybe we make this a script instead of a notebook.Edited to add: If we did use a script, we'd probably want to use
optparse
to specify the different parameters (i.e., it would replace ourparams
strategy).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know very little about Azimuth, so forgive me if this is a naive question! How is the reference generated here different from what is available on Zenodo? https://zenodo.org/records/4738021#.YJIW4C2ZNQI
Edit: I assume the difference is in the input downloaded from CELLxGENE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run the same in a script instead of a RMarkdown but same, I couldn't run it using one clic on "Source". 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am new to this, but I am now under the impression we can use Seurat to accomplish many of the same things as Azimuth: https://azimuth.hubmapconsortium.org/#General
(h/t @jashapiro)
Following those links, I assume we'd want to use this section as a reference: https://satijalab.org/seurat/articles/integration_mapping.html#cell-type-classification-using-an-integrated-reference
Being unable to run this successfully except for chunk by chunk gives me pause – it would be hard to test this notebook in GitHub Actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference you suggest can also be of interest but it contains 15 different organs fron a quick look. The one I wanted to use is only composed of cells from the kidney and from what I understood the annotation have been done by kidney experts.
But I could give a try with the one you suggest, might be more straightforward!
I'll compare the two on few samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be very curious about this result in general!
Another option would be to try to use Seurat #706 (comment) with the kidney dataset.
I am trying to avoid the
AzimuthReference()
bug if at all possible 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for looking into Seurat/Azimuth!
The label transfer using FindTransferAnchors and TransferData (described in the link you suggested https://satijalab.org/seurat/articles/integration_mapping.html#cell-type-classification-using-an-integrated-reference) is what I used before Seurat and Azimuth v5! I'll go back to it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also come out when using the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be appropriate to save the output of this chunk in
results
? Will the results be used later?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the same color palette as what is used below? So I'd recommend saving it as a variable so you only would need to change it one place:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be appropriate to save the output of this chunk in
results
? Will the results be used later?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to reflect the use of
params
(to let folks know where to look to see what is being used!) and where it will be saved.