Update #4
Merged
Update #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should increase throughput of the number of requests that can be made at once, while simultaneously following the new standard practice of using the rate limit bucket header. This is an accumulation of a lot of months of work between a few people and it has been tested extensively. From the testing it seems to work fine, but I'm not sure if it's the best way to do it. This changeset does not currently take into consideration sub rate limits yet, but the foundation is there via Route.metadata. In the future, this metadata will be filled in with the known sub rate limit implementation to allow them to have separate keys in the rate limit mapping. Co-authored-by: Josh <josh.ja.butt@gmail.com>
This is useful for cases where a rate limit is known to be extraordinarily high, but you still want to handle the error. This is common with routes such as emoji creation.
This is to speed up cases where someone is just querying the length of the underlying sequence. If anything else is done to the sequence then it is copied from the original iterator. This change should be mostly transparent.
Co-authored-by: Bryan Forbes <bryan@reigndropsfall.net>
This should allow them to be easier to use for users without requiring a lot of metaprogramming hackery if you want to involve state.
Co-authored-by: Danny <1695103+Rapptz@users.noreply.github.com>
Fix CooldownMapping generic typing and ensure other public methods have proper generics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.