StardewValley: Removed / standardize the usage of "run default tests" #4591
+2
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilbert1412
added
is: refactor/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
While investigating something else, I found that a couple of our classes were probably written before we had the base class handle the
run_default_tests()property, and they instead managed it themselves. For some I removed it, for some I fixed it, and for some I determines it was okay to let them self-determine and didn't touch it.How was this tested?
Ran the tests afterwards. It should be a very slight speed increase, as we now run fewer fill tests in the main pipeline, but not really noticeable. Maybe a second or so.