Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Faraday connection authorization warnings #117

Closed
wants to merge 1 commit into from

Conversation

rickychilcott
Copy link

Based on my read of https://lostisland.github.io/faraday/middleware/authentication, this should work fine in Faraday 1 and 2

Close #116

@apiology
Copy link

@hieubui149 : 👋 Hi there!

If you all are looking at PRs, can I point you towards #112 #113 and #114? They've been hanging out for a while.

@hieubui149
Copy link

hieubui149 commented Oct 27, 2021

Hello @rickychilcott, I am not the owner of this repo so I can't help you to merge this PR. I faced the same issue and it's floody spamming my logs. In order to get through it, I did monkey patching this class and it works just fine. Thank you!

@jrcasso
Copy link

jrcasso commented Nov 23, 2021

Applying this as a monkey patch worked for me. Thanks @hieubui149.

@AndersonDev
Copy link

AndersonDev commented May 20, 2022

@JW-Asana Hi! May we have this merged? There is too much warning spamming...

@BenTalagan
Copy link

BenTalagan commented May 21, 2022

Hi! This PR does not fix the faraday warning when using acces_token authentication. I have faced the problem today and this is how I fixed it. Would be nice to integrate it to the PR ?

module Asana
  module Authentication
    module OAuth2
      class AccessTokenAuthentication
        #... snip
        def configure(connection)
          @token = @token.refresh! if @token.expired?
          connection.params[:access_token] = @token.token
          connection.request :oauth2, { token_type: :param, param_name: 'access_token' }
        end
        #... snip
      end
    end
  end
end

@AndersonDev
Copy link

It's really priority, because I can't use CLI application, because of warnings

@igor-alexandrov
Copy link
Contributor

This is not relevant anymore after #152. @jv-asana please close.

@rickychilcott
Copy link
Author

I’ll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Faraday Warning on authorization
7 participants