Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Sky: Updated free site modal copy, size and console error #99218

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Feb 3, 2025

Related to #99211

Proposed Changes

  • Updated free site modal copy with translation compatibility
  • Increased the modal site so lines won't break
  • Make sure the changes are only applied to the treatment_cumulative group only

image

  • Fixed the key console error:

image

Testing Instructions

  • Go to /setup/onboarding - with the proper experiments set - and choose Big Sky
  • Go to plans page and click on start with a free plan
  • Check the modal's copy to ensure they're good and compatible with the previous translation while we wait for the new one to come.
  • Make sure you don't see any console error

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@paulopmt1 paulopmt1 requested a review from a team February 3, 2025 16:44
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2025
@paulopmt1 paulopmt1 self-assigned this Feb 3, 2025
@paulopmt1 paulopmt1 linked an issue Feb 3, 2025 that may be closed by this pull request
2 tasks
@matticbot
Copy link
Contributor

matticbot commented Feb 3, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~17 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +257 B  (+0.0%)      +26 B  (+0.0%)
entry-subscriptions         +126 B  (+0.0%)      +13 B  (+0.0%)
entry-login                 +126 B  (+0.0%)      +13 B  (+0.0%)
entry-domains-landing       +126 B  (+0.0%)      +13 B  (+0.0%)
entry-browsehappy           +126 B  (+0.1%)      +13 B  (+0.0%)
entry-stepper                +30 B  (+0.0%)       +4 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1909 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
plugins                    +14032 B  (+0.4%)    +5540 B  (+0.6%)
plans                      +14006 B  (+1.0%)    +5605 B  (+1.3%)
jetpack-app                +14006 B  (+3.0%)    +5540 B  (+3.7%)
update-design-flow          +1057 B  (+0.1%)     +143 B  (+0.0%)
link-in-bio-tld-flow        +1057 B  (+0.0%)     +143 B  (+0.0%)
signup                       +440 B  (+0.1%)       +4 B  (+0.0%)
checkout                     +220 B  (+0.0%)     +108 B  (+0.0%)
theme                        +208 B  (+0.0%)      -62 B  (-0.0%)
promote-post-i2              +180 B  (+0.0%)     -582 B  (-0.2%)
marketplace                  +170 B  (+0.0%)     +520 B  (+0.3%)
import                       +103 B  (+0.0%)      +32 B  (+0.0%)
account                      +103 B  (+0.0%)      +10 B  (+0.0%)
settings                      +90 B  (+0.0%)      -30 B  (-0.0%)
themes                        +89 B  (+0.0%)     -476 B  (-0.2%)
media                         +13 B  (+0.0%)       +6 B  (+0.0%)
jetpack-cloud-settings        +13 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~513 bytes added 📈 [gzipped])

name                                               parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected       +14006 B  (+3.1%)    +5536 B  (+3.8%)
async-load-signup-steps-plans                         +14006 B  (+3.1%)    +5540 B  (+3.8%)
async-load-design-blocks                                +635 B  (+0.0%)     +248 B  (+0.0%)
async-load-signup-steps-theme-selection                 +182 B  (+0.1%)       +5 B  (+0.0%)
async-load-signup-steps-design-picker                   -108 B  (-0.1%)      -20 B  (-0.1%)
async-load-signup-steps-website-content                 +103 B  (+0.0%)      +29 B  (+0.0%)
async-load-calypso-post-editor-media-modal               +13 B  (+0.0%)       -1 B  (-0.0%)
async-load-calypso-post-editor-editor-media-modal        +13 B  (+0.0%)       -1 B  (-0.0%)
async-load-calypso-my-sites-checkout-modal               +12 B  (+0.0%)     -504 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 changed the title Big Sky: Updated free site modal copy and size Big Sky: Updated free site modal copy, size and console error Feb 3, 2025
@p-jackson
Copy link
Member

I'm going to ask about what cohorts this gets rolled out to. It's a general improvement unrelated to the Big Sky work, so I'm wondering if it's what the treatment_cumulative experiment variation is for ...

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to ask whether this sort of change is supposed to be in the treatment_cumulative cohort or not
p1738638079552669-slack-C085HCWCEDN

@paulopmt1 paulopmt1 requested a review from a team as a code owner February 4, 2025 12:19
@paulopmt1
Copy link
Contributor Author

I want to ask whether this sort of change is supposed to be in the treatment_cumulative cohort or not

Thanks for checking that. Indeed, we want it to be the treatment_cumulative group only. Changed it here.

@paulopmt1 paulopmt1 requested a review from p-jackson February 4, 2025 12:21
@paulopmt1
Copy link
Contributor Author

Since we've already solved your issue, @p-jackson, I'm going ahead and deploying it. Let me know if you see any improvement, so I'll do it in a follow-up.

@paulopmt1 paulopmt1 force-pushed the update/copy-on-free-plan-modal branch from 8de2cae to cb5768e Compare February 4, 2025 12:38
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/copy-on-free-plan-modal on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: CfT feedback - Improve free plan modal copy
4 participants