-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big Sky: Updated free site modal copy, size and console error #99218
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~17 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1909 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~513 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
...sites/plans-features-main/components/plan-upsell-modal/components/suggested-plan-section.tsx
Outdated
Show resolved
Hide resolved
...sites/plans-features-main/components/plan-upsell-modal/components/suggested-plan-section.tsx
Show resolved
Hide resolved
I'm going to ask about what cohorts this gets rolled out to. It's a general improvement unrelated to the Big Sky work, so I'm wondering if it's what the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to ask whether this sort of change is supposed to be in the treatment_cumulative
cohort or not
p1738638079552669-slack-C085HCWCEDN
Thanks for checking that. Indeed, we want it to be the |
Since we've already solved your issue, @p-jackson, I'm going ahead and deploying it. Let me know if you see any improvement, so I'll do it in a follow-up. |
8de2cae
to
cb5768e
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Related to #99211
Proposed Changes
treatment_cumulative
group onlykey
console error:Testing Instructions
start with a free plan
Pre-merge Checklist