Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Remove unused logos #99229

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Components: Remove unused logos #99229

merged 3 commits into from
Feb 4, 2025

Conversation

mirka
Copy link
Member

@mirka mirka commented Feb 3, 2025

Proposed Changes

Remove corporate logo components that are no longer used.

Why are these changes being made?

  • Not used anywhere.
  • Non-A8C corporate logos should probably be consolidated to the client/assets/images/logos/ folder with the rest.
  • These logo SVGs have very particular title tags in them ("WordPress VIP client logo for ____") that aren't fit for reuse or translation.

Testing Instructions

  • App should build without errors.
  • Logos in the Devdocs should be pruned.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mirka mirka self-assigned this Feb 3, 2025
Comment on lines -51 to -59
<div className="logo-container">
<CloudLogo />
</div>
<div className="logo-container">
<WooLogo />
</div>
<div className="logo-container">
<VIPLogo />
</div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These Cloud and VIP logos were redundant in the list.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove-logo-components on your sandbox.

@@ -71,15 +71,10 @@ export type { RenderThumbFunction } from './pricing-slider/types';
// Logos
export { default as ClientLogoList } from './client-logo-list';
export { default as JetpackLogo } from './logos/jetpack-logo';
export { default as BloombergLogo } from './logos/bloomberg-logo';
export { default as CloudLogo } from './logos/cloud-logo';
export { default as CNNLogo } from './logos/cnn-logo';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other corporate logos will be addressed separately as they require a bit more clean up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see many of them (CNNLogo etc.) being used in a8c-for-agencies.

@mirka mirka marked this pull request as ready for review February 3, 2025 19:53
@mirka mirka requested a review from a team February 3, 2025 19:54
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 3, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~9060 bytes removed 📉 [gzipped])

name               parsed_size           gzip_size
async-load-design     -19559 B  (-1.3%)    -9060 B  (-2.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mirka mirka mentioned this pull request Feb 3, 2025
8 tasks
@jsnajdr
Copy link
Member

jsnajdr commented Feb 4, 2025

Nice find. Some corporate logos are displayed on the /plans/:site page for the top-tier VIP plan:

Screenshot 2025-02-04 at 9 42 11

But their SVGs are harcoded in the CLIENT_LIST array in packages/components/src/client-logo-list/client-list.tsx. The separate logo components you're removing are not used there.

Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mirka mirka merged commit 2ee115e into trunk Feb 4, 2025
13 checks passed
@mirka mirka deleted the remove-logo-components branch February 4, 2025 13:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants