-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Remove unused logos #99229
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
<div className="logo-container"> | ||
<CloudLogo /> | ||
</div> | ||
<div className="logo-container"> | ||
<WooLogo /> | ||
</div> | ||
<div className="logo-container"> | ||
<VIPLogo /> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These Cloud
and VIP
logos were redundant in the list.
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@@ -71,15 +71,10 @@ export type { RenderThumbFunction } from './pricing-slider/types'; | |||
// Logos | |||
export { default as ClientLogoList } from './client-logo-list'; | |||
export { default as JetpackLogo } from './logos/jetpack-logo'; | |||
export { default as BloombergLogo } from './logos/bloomberg-logo'; | |||
export { default as CloudLogo } from './logos/cloud-logo'; | |||
export { default as CNNLogo } from './logos/cnn-logo'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other corporate logos will be addressed separately as they require a bit more clean up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see many of them (CNNLogo
etc.) being used in a8c-for-agencies.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~9060 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed Changes
Remove corporate logo components that are no longer used.
Why are these changes being made?
client/assets/images/logos/
folder with the rest.title
tags in them ("WordPress VIP client logo for ____") that aren't fit for reuse or translation.Testing Instructions
Pre-merge Checklist