Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupon Box Experiment Code Clean Up #99243

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

briowill
Copy link
Contributor

@briowill briowill commented Feb 3, 2025

Related to #
#93516
#95364

Proposed Changes

Remove unused code related to experiment

Why are these changes being made?

We have concluded the hide coupon box experiment and now need to remove unused code related to the test.

Testing Instructions

  1. Apply branch
  2. Navigate to the checkout eg. *http://calypso.localhost:3000/start
  3. Confirm you are seeing the Have a coupon section

image

@briowill briowill requested a review from a team as a code owner February 3, 2025 23:30
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~77 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
entry-main        -176 B  (-0.0%)      -77 B  (-0.0%)
entry-login       -176 B  (-0.0%)      -77 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~243 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
checkout       -681 B  (-0.0%)     -243 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~386 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal                                             -857 B  (-0.1%)     -322 B  (-0.1%)
async-load-calypso-blocks-editor-checkout-modal                                        -681 B  (-0.1%)     -243 B  (-0.1%)
async-load-signup-steps-page-picker                                                    -380 B  (-0.1%)     -160 B  (-0.1%)
async-load-purchase-modal-wrapper                                                      -380 B  (-0.1%)     -160 B  (-0.1%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       -380 B  (-0.1%)     -160 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@briowill briowill requested a review from gmovr February 3, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants