Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support pressure and tilt on macos #18082

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

AkiSakurai
Copy link
Contributor

@AkiSakurai AkiSakurai commented Jan 30, 2025

What does the pull request do?

Adding pen pressure and tilt support on macos

What is the current behavior?

Can not receive the pen pressure and tile information on macos

What is the updated/expected behavior with this PR?

Can receive the pen pressure and tile information on macos

How was the solution implemented (if it's not obvious)?

Tilt has to be inverted on macos.

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

fix #3540

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054649-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Jan 30, 2025

  • All contributors have signed the CLA.

@AkiSakurai
Copy link
Contributor Author

@cla-avalonia agree

Copy link
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

A few minor changes are needed but this looks good overall.

src/Avalonia.Base/Input/PointerPoint.cs Outdated Show resolved Hide resolved
native/Avalonia.Native/src/OSX/AvnWindow.mm Outdated Show resolved Hide resolved
native/Avalonia.Native/src/OSX/AvnView.mm Show resolved Hide resolved
Copy link
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@MrJul MrJul enabled auto-merge February 1, 2025 15:44
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054691-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added this pull request to the merge queue Feb 1, 2025
Merged via the queue into AvaloniaUI:master with commit 21ecbf3 Feb 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressure Pen (e.g. Wacom) API
4 participants