[Service Connector] Fix Azure/azure-cli-extension#7235: az containerapp connection: Create postgresql-flexible
#28112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CLI commands to explicitly use JSON output format. This fixes
the issue described in Azure/azure-cli-extension#7235 but other
commands might have similar issues.
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007 and
zhoxing-ms
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl,
jijohn14 and
Greedygre
dbroeglin
changed the title
dbroeglin
changed the title
zhoxing-ms
changed the title
az containerapp connection: Create postgresql-flexible
|
Could you add some test cases for this PR? |
|
@dbroeglin Any update? |
|
@zhoxing-ms I don't have much bandwidth right now. I believe non regression would be covered by existing tests. I will try to schedule some time in March to work on tests. |
|
@dbroeglin OK, could we move it's release to the next sprint (04-02)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{containerapp} Update CLI commands to explicitly use JSON output format.
Related command
az containerapp connection create postgres-flexible
Description<4!--Mandatory-->
Update CLI commands to explicitly use JSON output format. This fixes
the issue described in Azure/azure-cli-extension#7235 but other
commands might have similar issues.
Testing Guide
Change the default format:
az config set core.output=tableRun :
az containerapp connection create postgres-flexible ...This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.