[Backup] az backup restore restore-disks: Add support for disk restore in edge-zone backups and support for TWN + TNW CRR
#28150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| backup restore restore-disks | cmd backup restore restore-disks added parameter restore_to_edge_zone |
|
Backup |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007,
jsntcy and
zhoxing-ms
zhoxing-ms
changed the title
az backup restore restore-disks: Add support for disk restore in edge-zone backups and support for TWN + TNW CRR
zhoxing-ms
reviewed
Jan 18, 2024
Comment on lines
+138
to
+139
| result = client.begin_register(vault_name, resource_group_name, fabric_name, container_name, param, | ||
| cls=cust_help.get_pipeline_response, polling=False).result() |
There was a problem hiding this comment.
May I ask why you need to disable the logic of polling in the code?
There was a problem hiding this comment.
The SDK was changed to return LROPoller instead, so I made the change to parse it correctly.
There was a problem hiding this comment.
Yes, what I mean is what problems would there be if using polling?
There was a problem hiding this comment.
You can try to obtain results from LROPoller in the following ways
There was a problem hiding this comment.
Yes, what I mean is what problems would there be if using polling?
I'm not entirely sure, honestly. I'm just following the pattern we've been using previously in our code:
There was a problem hiding this comment.
Okay, you can keep the original code style for now. If you have a need of progress bar for long running operation, you can consider changing the code style to the one we recommend in the future.
zhoxing-ms
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az backup restore restore-disksDescription
Added the
--restore-to-edge-zonethree-state-flag parameter forrestore-disks. When this parameter is provided, and for OriginalLocation restores, the extendedLocation property of the trigger restore request body is populated with the equivalent details from the recovery point.Testing Guide
For a VM deployed to an edge zone, backed up to a vault, we can trigger a restore with:
--restore-mode OriginalLocation, or--restore-to-edge-zoneand we should be able to back up successfully. If we inspect request body, it will contain an ExtendedLocation element.
Automated tests have not been written as the testing subscription does not have edge zones enabled yet, but it has been tested manually.
History Notes
[Backup] Add support for disk restore in edge-zone backups
[Backup] Support for Taiwan North and Taiwan North-West Cross region restore
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.