-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Containerapp] az containerapp update
: Fix issue for minReplicas in --yaml
or --min-replicas
is not set when the value is 0
#28163
Merged
zhoxing-ms
merged 3 commits into
Azure:dev
from
Greedygre:xinyu/20240110_fix_min_replica
Jan 11, 2024
Merged
[Containerapp] az containerapp update
: Fix issue for minReplicas in --yaml
or --min-replicas
is not set when the value is 0
#28163
zhoxing-ms
merged 3 commits into
Azure:dev
from
Greedygre:xinyu/20240110_fix_min_replica
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007 and
yanzhudd
January 10, 2024 06:49
Containerapp |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl and
jijohn14
January 10, 2024 06:49
Juliehzl
reviewed
Jan 10, 2024
Greedygre
changed the title
[Containerapp]
[Containerapp] Jan 10, 2024
az containerapp update
: Fix issue for minReplicas in --yaml or --min-replicas is not set when the value is 0az containerapp update
: Fix issue for minReplicas in --yaml
or --min-replicas
is not set when the value is 0
Juliehzl
approved these changes
Jan 11, 2024
zhoxing-ms
approved these changes
Jan 11, 2024
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
… `--yaml` or `--min-replicas` is not set when the value is 0 (Azure#28163)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp update --min-replicas --yaml
Fix issue:
Azure/azure-cli-extensions#5391
Fix bug for minReplicas in --yaml or --min-replicas is not set when the value is 0.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.