{AKS} fix test case of trustedaccess #28171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YitongFeng-git
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
AKS |
microsoft-github-policy-service
bot
requested review from
yonzhan and
FumingZhang
microsoft-github-policy-service
bot
added
Auto-Assign
YitongFeng-git
force-pushed
the
yife/tatest
branch
from
e85e36b to
15e4646
Compare
YitongFeng-git
force-pushed
the
yife/tatest
branch
from
15e4646 to
fb2e655
Compare
added 2 commits
January 12, 2024 14:09
4 tasks
FumingZhang
approved these changes
Jan 12, 2024
zhoxing-ms
approved these changes
Jan 12, 2024
Merged
3 tasks
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
fix test case of trustedaccess
E Message: The value of parameter properties.roles is invalid. Error details: non-exist role: Microsoft.Compute/virtualMachineScaleSets/test-node-reader, please refer to http://aka.ms/aks/ta/role to list available roles. Please see https://aka.ms/aks-naming-rules for more details.
The Microsoft.Compute/virtualMachineScaleSets/test-node-reader is internal role, the cli test subscription can not show this role, changed to a public role Microsoft.MachineLearningServices/workspaces/mlworkload can fix this
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.