-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppService] functionapp create
: Check if storage account is network restricted
#30605
base: dev
Are you sure you want to change the base?
Conversation
❌AzureCLI-FullTest
|
Hi @kamperiadis, |
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
functionapp create | cmd functionapp create added parameter configure_networking_later |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
d4417f0
to
1f976d5
Compare
I notice that the assertion for tests fail if there are resources that we create on customers' behalf. Does it mean we can only run those tests in live mode instead of relying on recordings? @zhoxing-ms |
Why can't these resources be dynamically created in the tests? |
The intention is for the command to create those resources in behalf of the customer, as opposed to the customer (or tests) to create them separately. |
If the resource is dynamically created through CLI commands in the test code, the create request will also be recorded in the recording file, so it supports execution in replay mode |
@zhoxing-ms The resources that are internally created by the command (not in the test code but in the command itself), the tool has trouble determining that it is the same call. For instance, in the changes I made, I am creating a new file share resource (e.g. fileServices/default/shares/functionapp000002092f77bfe918) when the
|
Could you please show me the related code link? |
@zhoxing-ms This is where we create a file share when the customer runs
|
Related command
az functionapp create
Description
We need to throw exceptions during the function app creation process if the storage account is network restricted
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.