[Storage] Fix #30635: az storage copy: Update to latest AzCopy download link with version 10.27.1
#30640
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
evelyn-ys and
yonzhan
calvinhzy
changed the title
az storage copy: Update to latest AzCopy download link with version 10.27.1az storage copy: Update to latest AzCopy download link with version 10.27.1
| @@ -56,7 +56,8 @@ def install_azcopy(self, install_location): | |||
| install_dir = os.path.dirname(install_location) | |||
| if not os.path.exists(install_dir): | |||
| os.makedirs(install_dir) | |||
| base_url = 'https://azcopyvnext.azureedge.net/release20211027/azcopy_{}_{}_{}.{}' | |||
| base_url = 'https://azcopyvnext-awgzd8g7aagqhzhe.b02.azurefd.net/releases/release-10.27.1-20241113/' \ | |||
There was a problem hiding this comment.
Is that correct? From my perspective, it should be something like:
https://azcopyvnext-awgzd8g7aagqhzhe.b02.azurefd.net/release20211027/azcopy_{}_{}_{}.{}
That part release-10.27.1-20241113/ sounds unnecessary, otherwise you should be able to pass the version also as an argument on the build of the URL
That currently way, you kinda make unnecessary the AZCOPY_VERSION.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Since the old links have been deprecated https://learn.microsoft.com/en-us/azure/cdn/edgio-retirement-faq
Switching to the latest links from AzCopy guide https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-v10?tabs=dnf#download-the-azcopy-portable-binary
Fix #30635
Testing Guide
History Notes
[Storage]
az storage copy: Update to latest AzCopy download link with version 10.27.1This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.