Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backup] 'az backup restore restore-disks': Update to support NoZone as a valid target-zone #30720

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

SourabhSomnathGholap
Copy link

Related command

'az backup restore restore-disks'

Description

In this PR I have added NoZone as a valid target-zone in 'az backup restore restore-disks'. Earlier valid target zones were 1,2 and 3.
Additionally, I have made code changes to support cross-zonal restore from snapshot and vault standard RP.

Testing Guide

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

Copy link

Hi @SourabhSomnathGholap,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 27, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@zubairabid zubairabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have some clarifying questions otherwise.

@SourabhSomnathGholap SourabhSomnathGholap marked this pull request as ready for review January 27, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Backup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants