[Storage] [DataMovement] Put EditorBrowsable(Never) for not using interfaces #47939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnguye
requested review from
seanmcc-msft,
jaschrep-msft,
schaabs,
tg-msft,
jalauzon-msft and
nickliu-msft
as code owners
|
API change check API changes are not detected in this pull request. |
| protected internal abstract bool IsContainer { get; } | ||
|
|
||
| /// <summary> | ||
| /// Gets the Uri of the Storage Resource. | ||
| /// </summary> | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public abstract Uri Uri { get; } |
There was a problem hiding this comment.
I think Uri may be useful to leave so customers are able to identity their resource objects if they need to. I also sort of feel this way about IsContainer but we marked that as protected internal meaning we didn't want customers to use it so ehh
| using System.IO; | ||
|
|
||
| namespace Azure.Storage.DataMovement | ||
| { | ||
| /// <summary> | ||
| /// Abstract class for checkpoint data related to a specific resource type. | ||
| /// </summary> | ||
| [EditorBrowsable(EditorBrowsableState.Never)] |
There was a problem hiding this comment.
nit: Did we check if marking a class as EB(never) also marks its properties?
| @@ -13,46 +14,55 @@ public class TransferProperties | |||
| /// <summary> | |||
| /// Contains the transfer ID which to rehydrate the StorageResource from. | |||
| /// </summary> | |||
| [EditorBrowsable(EditorBrowsableState.Never)] | |||
There was a problem hiding this comment.
Maybe since we are handing these back to customers when they call GetTransfers we should have some info visible. Maybe TransferId, SourceUri, and DestinationUri?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
[EditorBrowsable(EditorBrowsableState.Never)]for DataMovement interfaces that are not meant to be used publicly.