Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Discourse Links to Relevant Sections #272

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

abanuelo
Copy link
Contributor

Description

Discourse is not set up for Scenic 🥳 🎉 . Let's add references to it where relevant!

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from dfremont and Eric-Vin May 22, 2024 23:36
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@836b0f8). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage        ?   91.30%           
=======================================
  Files           ?       54           
  Lines           ?    13520           
  Branches        ?        0           
=======================================
  Hits            ?    12345           
  Misses          ?     1175           
  Partials        ?        0           

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor comments.

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
abanuelo and others added 2 commits June 6, 2024 13:41
Co-authored-by: Daniel Fremont <dfremont@ucsc.edu>
Co-authored-by: Daniel Fremont <dfremont@ucsc.edu>
@abanuelo abanuelo requested a review from dfremont June 6, 2024 20:42
@dfremont dfremont merged commit 1d434f9 into main Jun 7, 2024
26 checks passed
@dfremont dfremont deleted the abanuelo/add-discourse branch June 7, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants