feat: improve errors if wallet subaccount doesnt exist (#82)

* fix: include wallet name in rpc error

* feat: check if subaccount exists on startup

onchain/wallet/wallet.go

@@ -417,7 +417,7 @@ func Login(credentials *Credentials) (*Wallet, error) {
 	if credentials.Encrypted() {
 		return nil, errors.New("credentials are encrypted")
 	}
-	wallet := &Wallet{currency: credentials.Currency, name: credentials.Name, subaccount: credentials.Subaccount}
+	wallet := &Wallet{currency: credentials.Currency, name: credentials.Name}
 	login := make(map[string]any)
 
 	if credentials.Mnemonic != "" {
@@ -451,6 +451,13 @@ func Login(credentials *Credentials) (*Wallet, error) {
 		return nil, err
 	}
 	logger.Debugf("Logged in: %v", result)
+
+	if credentials.Subaccount != nil {
+		if _, err := wallet.SetSubaccount(credentials.Subaccount); err != nil {
+			logger.Errorf("Failed to set subaccount for wallet %s. You might have to resync it using GetSubaccounts: %v", credentials.Name, err)
+		}
+	}
+
 	return wallet, nil
 }
 

rpcserver/router.go

@@ -735,7 +735,7 @@ func (server *routedBoltzServer) serializeWallet(wal onchain.Wallet) (*boltzrpc.
 	balance, err := wal.GetBalance()
 	if err != nil {
 		if !errors.Is(err, wallet.ErrSubAccountNotSet) {
-			return nil, handleError(err)
+			return nil, handleError(fmt.Errorf("could not get balance for wallet %s: %w", wal.Name(), err))
 		}
 	} else {
 		result.Balance = serializeWalletBalance(balance)
@@ -759,7 +759,7 @@ func (server *routedBoltzServer) GetWallets(_ context.Context, request *boltzrpc
 		if (currency == "" || current.Currency() == currency) && (!current.Readonly() || request.GetIncludeReadonly()) {
 			wallet, err := server.serializeWallet(current)
 			if err != nil {
-				return nil, handleError(err)
+				return nil, err
 			}
 			response.Wallets = append(response.Wallets, wallet)
 		}