Ensure row access doesn't mutate state, see: sveltejs/svelte#12457

Careswitch · Jul 16, 2024 · 94f0694 · 94f0694
1 parent 6d1437c
commit 94f0694
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 19 deletions.
diff --git a/.changeset/friendly-squids-knock.md b/.changeset/friendly-squids-knock.md
@@ -0,0 +1,5 @@
+---
+'@careswitch/svelte-data-table': patch
+---
+
+Ensure row access doesn't mutate state, see: https://github.com/sveltejs/svelte/issues/12457
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/lib/DataTable.svelte.ts b/src/lib/DataTable.svelte.ts
@@ -40,9 +40,8 @@ export class DataTable<T> {
 	#globalFilter = $state<string>('');
 	#globalFilterRegex = $state<RegExp | null>(null);
 
-	#isFilterDirty = $state(true);
-	#isSortDirty = $state(true);
-
+	#isFilterDirty = true;
+	#isSortDirty = true;
 	#filteredData: T[] = [];
 	#sortedData: T[] = [];
 
@@ -165,6 +164,11 @@ export class DataTable<T> {
 	 * @returns {T[]} An array of rows for the current page.
 	 */
 	get rows() {
+		// React to changes in filter state and sort state
+		this.#filterState;
+		this.#sortState;
+		this.#globalFilterRegex;
+
 		this.#applyFilters();
 		this.#applySort();
 		const startIndex = (this.currentPage - 1) * this.#pageSize;