Avoid using Str #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "str" library is still shipped together with the OCaml stdlib but generally considered obsolete; better alternatives include the `re` library that we use in Catala, but here, the use-case being very simple, `Scanf` is powerful enough and reasults in more readable code. To be honest, my main motivation was avoiding the need to link another dependency into the Catala runtime :) Note/advice: side effects within `assert` should be avoided, `assert` in OCaml is not a standard function and it would break your code if compiled with the `-noassert` flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "str" library is still shipped together with the OCaml stdlib but generally considered obsolete; better alternatives include the
relibrary that we use in Catala, but here, the use-case being very simple,Scanfis powerful enough and reasults in more readable code.To be honest, my main motivation was avoiding the need to link another dependency into the Catala runtime :)
Note/advice: side effects within
assertshould be avoided,assertin OCaml is not a standard function and it would break your code if compiled with the-noassertflag.