Avoid checking for null on non-nullable property for projection

[glen-84]

Summary of the changes (Less than 80 chars)

• Check the nullability of properties before doing a null check.

Closes #6604.

---

• I'm not sure what context.InMemory is about.
• Is there an existing utility function/extension method for checking this nullability?
• Should these nullability checks be cached?

[glen-84]

@PascalSenn Is this feasible?

[PascalSenn]

@glen-84

We did remove it once for ef core and then added it again:
#6604 (comment)

So i am not sure what to do now. I believe if you do not do the nullcheck then it will include all the fields from the child or something like this.

[glen-84]

You removed it completely, or conditionally based on the nullability of the property?

Should I be seeing something significant in the test snapshots, or is there no test that would highlight the previous issue? If not, then I think that we need that test to exist in order to have some more confidence here.

[PascalSenn]

This is the context:
28ed6ae

So you only apply it when the property is nullable and ef does not complain?

[glen-84]

So you only apply it when the property is nullable and ef does not complain?

By "does not complain", you mean that the tests in HotChocolate.Data.Projections.SqlServer.Tests pass? If so, yes, they all pass.

[glen-84]

This will quite likely fix these issues as well:

• Projection cause "Index out of range" on Database first EF core (net 6)  #5229
• Owned entity returning null if any property is null in net7 #5542

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (2df21d7) to head (3072c7d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6706      +/-   ##
==========================================
- Coverage   73.92%   73.91%   -0.02%     
==========================================
  Files        2853     2853              
  Lines      148656   148658       +2     
  Branches    17271    17271              
==========================================
- Hits       109895   109876      -19     
- Misses      33007    33032      +25     
+ Partials     5754     5750       -4     

Flag	Coverage Δ
unittests	73.91% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.