Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that, when we start using LazyBroadcast in ClimaAtmos, we'll use the
Absent
type, so that broadcasting will entirely skip arithmetic operations against them. In this implementation, I've also defined a helper that we should be able to use,skip_materialize
, that we can use to even completely elide operations in cases where we have expressions like@. x += Absent()
-- we can makematerialize!(dest, ::Base.Broadcasted{<:AbsentStyle}) = nothing
here.For example, in CliMA/ClimaAtmos.jl#3540, we'll be able to use:
There are a few advantages of doing this:
@. x += Absent()
case (which will happen often early on before we begin fusing tendencies)Absent
objects during broadcasted construction could also help with compile timesI added
LazyBroadcast
to the test dependencies here for convenience, but we could remove it.Credit to @dennisYatunin, for most of the implementation in CliMA/ClimaTimeSteppers.jl#264