derive: Support #[row(crate = ...)]
#189
Open
+81
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
serprex
previously approved these changes
Dec 12, 2024
YBoy-git
changed the title
#[row(crate = ...)]
serprex
reviewed
Dec 14, 2024
serprex
previously approved these changes
Dec 14, 2024
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
serprex
approved these changes
Dec 15, 2024
loyd
approved these changes
Dec 15, 2024
| @@ -0,0 +1,2 @@ | |||
| mod row; | |||
| pub use row::Row; | |||
There was a problem hiding this comment.
pub(crate) (and all below). It seems this subcrate doesn't use https://github.com/ClickHouse/clickhouse-rs/blob/main/Cargo.toml#L17
| @@ -35,12 +55,14 @@ fn column_names(data: &DataStruct, cx: &Ctxt, container: &Container) -> TokenStr | |||
|
|
|||
| // TODO: support wrappers `Wrapper(Inner)` and `Wrapper<T>(T)`. | |||
| // TODO: support the `nested` attribute. | |||
| // TODO: support the `crate` attribute. | |||
| #[proc_macro_derive(Row)] | |||
| #[proc_macro_derive(Row, attributes(row))] | |||
| pub fn row(input: proc_macro::TokenStream) -> proc_macro::TokenStream { | |||
There was a problem hiding this comment.
This patch deserves a docstring
| type Error = &'a syn::Attribute; | ||
|
|
||
| fn try_from(attr: &'a syn::Attribute) -> Result<Self, Self::Error> { | ||
| if attr.path().is_ident(ATTRIBUTE_NAME) { |
There was a problem hiding this comment.
Not very important (because it's a private API), but it's more straightforward to return an error (even a simple string) and panic in the From instance.
|
|
||
| impl From<&[syn::Attribute]> for Attributes { | ||
| fn from(attrs: &[syn::Attribute]) -> Self { | ||
| let mut row = None; |
There was a problem hiding this comment.
What is point to use None here instead of Row::default()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
derivecrate.#[row(crate = ...)]attribute