Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LONDON | DONARA BLANC | DATA FLOWS | WEEK 2| BOOK PROJECT PROJECT #150

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

donarbl
Copy link

@donarbl donarbl commented Jan 18, 2025

Self checklist

  • [X ] I have committed my files one by one, on purpose, and for a reason
  • X[ ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ X] I have tested my changes
  • [X ] My changes follow the style guide
  • [ X] My changes meet the requirements of this task

Changelist

Hello, I've mainly updated the script.js code to fix syntax, naming consistency, and added author value.

Questions

Ask any questions you have for your reviewer.

@donarbl donarbl added the Needs Review Participant to add when requesting review label Jan 18, 2025
@tyzia tyzia added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jan 18, 2025
@tyzia
Copy link

tyzia commented Jan 18, 2025

Overall looks good. Please, remove files not related to your task - package.json & package-lock.json from this PR. You might want to add them to .gitignore file.

@donarbl
Copy link
Author

donarbl commented Jan 19, 2025

@tyzia Hello! Thank you for the review, a question, do I remove the files through the vs code and then push the changes or here in github ? Thank you.

@donarbl donarbl added Complete Participant to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants