London11 | Karla Grajales | Module-Data-Groups | Sprint-3 Debugging Book-Library-Book

[Grajales-K]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

This project taught us key skills in debugging and version control. I resolved Git branch issues, handled cherry-picks, and fixed event listener errors in JavaScript. Clear boolean condition checks improved code reliability, and we efficiently resolved merge conflicts during cherry-pick operations. Finally, I emphasized the importance of maintaining a disciplined Git workflow to manage changes systematically.

Questions

Ask any questions you have for your reviewer.

[cjyuan]

• On page load, is it necessary to call render() twice?

• In terms of input validation,

1. Are all input properly checked?
2. Can .value be null? (Do we need to check someInputElement.value == null?)
3. What if a user enters only space characters in the "title" input field?
4. What if a users enters -1 or 3.1416 in the "pages" input field?

There is also some errors in index.html. Perhaps an HTML validator can quickly help you identify them.

[Grajales-K]

• On page load, is it necessary to call render() twice?
• In terms of input validation,

1. Are all input properly checked?
2. Can .value be null? (Do we need to check someInputElement.value == null?)
3. What if a user enters only space characters in the "title" input field?
4. What if a users enters -1 or 3.1416 in the "pages" input field?

There is also some errors in index.html. Perhaps an HTML validator can quickly help you identify them.

[cjyuan]

After you fix the code that check for page numbers. Feel free to mark this as Completed.

[cjyuan]

Line 38 looks weird. What does that compare?