CYF London | Rihanna Poursoltani | Module-Data-Groups | Sprint 3 | Quote Generator App #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch also contains modified files from Sprint-1. Can you try rebase it onto main? |
RihannaP
force-pushed
the
sprint-3-quote-generator
branch
from
6a3c685 to
8b7427c
Compare
RihannaP
force-pushed
the
sprint-3-quote-generator
branch
from
8b7427c to
992e969
Compare
|
cjyuan
reviewed
Jan 14, 2025
| authorLine.textContent = randomArr.author; | ||
| } | ||
|
|
||
| window.onload = randomQuoteGenerate; |
There was a problem hiding this comment.
Suggestion: Between the following two approaches for assigning event listener
window.onload = event_listenerwindow.addEventListener('load', event_listener)
the latter is better.
cjyuan
added
Reviewed
RihannaP
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.