Merge pull request #563 from dxw/fix/1165-support-cols-headed-by-inte…

…gers-in-multi-column-mgmt-charge-calc

(fix) Support integer column headings in mgnmt charge calculation

app/models/framework/management_charge_calculator/column_based.rb

@@ -9,7 +9,7 @@ def initialize(varies_by:, value_to_percentage:)
       end
 
       def calculate_for(entry)
-        column_names_for_entry = Array(varies_by).map { |column| entry.data.dig(column).downcase }
+        column_names_for_entry = Array(varies_by).map { |column| entry.data.dig(column).to_s.downcase }
         percentage = percentage_for(column_names_for_entry)
 
         if percentage.nil?

spec/models/framework/management_charge_calculator/column_based_spec.rb

@@ -28,6 +28,19 @@
     expect(calculator.calculate_for(entry)).to eq(6.1725) # 5% of 123.45
   end
 
+  it 'handles column values that are integers' do
+    entry = FactoryBot.create(:submission_entry, total_value: 123.45, data: { test_value: 1 })
+
+    calculator = Framework::ManagementChargeCalculator::ColumnBased.new(
+      varies_by: 'test_value',
+      value_to_percentage: {
+        '1': BigDecimal('5')
+      }
+    )
+
+    expect(calculator.calculate_for(entry)).to eq(6.1725) # 5% of 123.45
+  end
+
   it 'rounds to four decimal places' do
     entry = FactoryBot.create(:submission_entry, total_value: 42.424242, data: { test_value: 'test' })