Implement --openBrowser CLI flag #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
CtrlSpice
commented
Jan 27, 2025
CtrlSpice
commented
- Implement an --openBrowser flag (true by default)
- Move the logic for opening the browser into main, where the CLI stuff happens
jmorrell
approved these changes
Jan 29, 2025
desktopcollector/main.go
Outdated
Comment on lines
88
to
89
| rootCmd.Flags().BoolVar(&openBrowserFlag, "openBrowser", true, "Open the browser automatically on launch") | ||
| rootCmd.Flags().IntVar(&browserPortFlag, "browserPort", 8000, "The port number where we expose our data") |
There was a problem hiding this comment.
I think kebab-case is more traditional for CLI arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.